SbloodyS commented on code in PR #10373:
URL: https://github.com/apache/dolphinscheduler/pull/10373#discussion_r891942836


##########
dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/resources/docker/file-manage/common.properties:
##########
@@ -85,3 +85,6 @@ aws.access.key.id=accessKey123
 aws.secret.access.key=secretKey123
 aws.region=us-east-1
 aws.endpoint=http://s3:9000
+
+# Task resource limit state
+task.resource.limit.state=false

Review Comment:
   > we set false by default, and it will not available when user set any 
number of CPU and mem in web UI, should we set `true` as default?
   
   I had a discussion with @kezhenxu94 in this problemes. Because our current 
E2E test is based on docker, ```systemd``` and ```CGroup``` are not supported 
by default in the docker container. In the future, I will try to enable non 
docker mode tests in E2E and then improve the tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to