Amy0104 commented on code in PR #10373:
URL: https://github.com/apache/dolphinscheduler/pull/10373#discussion_r891924391
##########
dolphinscheduler-ui/src/locales/en_US/project.ts:
##########
@@ -308,6 +308,8 @@ export default {
task_group_name: 'Task group name',
task_group_queue_priority: 'Priority',
number_of_failed_retries: 'Number of failed retries',
+ cpu_quota: 'Cpu quota',
Review Comment:
It seems to be better that the cpu be capitalized.
##########
dolphinscheduler-ui/src/views/projects/task/components/node/format-data.ts:
##########
@@ -409,7 +409,9 @@ export function formatParams(data: INodeData): {
timeout: data.timeoutFlag ? data.timeout : 0,
timeoutFlag: data.timeoutFlag ? 'OPEN' : 'CLOSE',
timeoutNotifyStrategy: data.timeoutFlag ? timeoutNotifyStrategy : '',
- workerGroup: data.workerGroup
+ workerGroup: data.workerGroup,
+ cpuQuota: data.cpuQuota,
+ memoryMax: data.memoryMax
Review Comment:
It is better to set a default value for the cupQuota and the memoryMax when
other tasks don't need the two parameters.
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -308,6 +308,8 @@ export default {
task_group_name: '任务组名称',
task_group_queue_priority: '组内优先级',
number_of_failed_retries: '失败重试次数',
+ cpu_quota: 'Cpu配额',
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
