caishunfeng commented on code in PR #10373:
URL: https://github.com/apache/dolphinscheduler/pull/10373#discussion_r891983337
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -486,6 +486,8 @@ CREATE TABLE t_ds_task_definition
delay_time int(11) DEFAULT '0',
task_group_id int(11) DEFAULT NULL,
task_group_priority tinyint(4) DEFAULT '0',
+ cpu_quota int(11) DEFAULT '-1' NOT NULL,
+ memory_max int(11) DEFAULT '-1' NOT NULL,
Review Comment:
>how about using single column as string and store and parse json
Do you mean the `task_params`?
I think if the parameter is generic and matches all tasks, it can add a new
column.
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -486,6 +486,8 @@ CREATE TABLE t_ds_task_definition
delay_time int(11) DEFAULT '0',
task_group_id int(11) DEFAULT NULL,
task_group_priority tinyint(4) DEFAULT '0',
+ cpu_quota int(11) DEFAULT '-1' NOT NULL,
+ memory_max int(11) DEFAULT '-1' NOT NULL,
Review Comment:
>how about using single column as string and store and parse json
Do you mean the `task_params`?
I think if the parameter is generic and matches all tasks, it can add a new
column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
