caishunfeng commented on code in PR #10373:
URL: https://github.com/apache/dolphinscheduler/pull/10373#discussion_r891989936
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThread.java:
##########
@@ -1307,6 +1311,7 @@ private void submitPostNode(String parentNodeCode) {
}
TaskInstance task = createTaskInstance(processInstance,
taskNodeObject);
taskInstances.add(task);
+ logger.info("task {} add to stand by list, cpuQuota: {}",
task.getName(), task.getCpuQuota());
Review Comment:
remove if not use.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/AbstractCommandExecutor.java:
##########
@@ -142,6 +148,34 @@ private void buildProcess(String commandFile) throws
IOException {
printCommand(command);
}
+ private void generateCgroupCommand(List<String> command) {
Review Comment:
can we add some example comment here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
