zhongjiajie commented on code in PR #10373:
URL: https://github.com/apache/dolphinscheduler/pull/10373#discussion_r892002958
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -486,6 +486,8 @@ CREATE TABLE t_ds_task_definition
delay_time int(11) DEFAULT '0',
task_group_id int(11) DEFAULT NULL,
task_group_priority tinyint(4) DEFAULT '0',
+ cpu_quota int(11) DEFAULT '-1' NOT NULL,
+ memory_max int(11) DEFAULT '-1' NOT NULL,
Review Comment:
> > I think if the parameter is generic and matches all tasks, it can add a
new column.
>
> But it is not, it only for some of task types which may download resource
file form resource center. and user have to use those resource file. for
example users can use or can not use shell with resource files.
ignore this comment, I finally get that we want to limit the linux resource
in task, in this case I think we could add new column for it 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
