caishunfeng commented on code in PR #10406: URL: https://github.com/apache/dolphinscheduler/pull/10406#discussion_r894971000
########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/java/org/apache/dolphinscheduler/plugin/registry/mysql/MysqlOperator.java: ########## @@ -0,0 +1,294 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.registry.mysql; + +import org.apache.dolphinscheduler.common.utils.NetUtils; +import org.apache.dolphinscheduler.plugin.registry.mysql.model.DataType; +import org.apache.dolphinscheduler.plugin.registry.mysql.model.MysqlRegistryData; +import org.apache.dolphinscheduler.plugin.registry.mysql.model.MysqlRegistryLock; + +import org.apache.commons.lang3.StringUtils; + +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.sql.SQLIntegrityConstraintViolationException; +import java.sql.Statement; +import java.sql.Timestamp; +import java.util.ArrayList; +import java.util.List; + +import javax.sql.DataSource; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Used to CRUD from mysql + */ +public class MysqlOperator { + + private static final Logger logger = LoggerFactory.getLogger(MysqlOperator.class); + + private final DataSource dataSource; + + public MysqlOperator(DataSource dataSource) { + this.dataSource = dataSource; + } + + public void healthCheck() throws SQLException { + String sql = "select 1 from t_ds_mysql_registry_data"; + try (Connection connection = dataSource.getConnection(); + PreparedStatement preparedStatement = connection.prepareStatement(sql)) { + // if no exception, the healthCheck success + preparedStatement.executeQuery(); + } + } + + public List<MysqlRegistryData> queryAllMysqlRegistryData() throws SQLException { + String sql = "select id, `key`, data, type, createTime, lastUpdateTime from t_ds_mysql_registry_data"; Review Comment: Can the style of mapper be used uniformly here? ########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/java/org/apache/dolphinscheduler/plugin/registry/mysql/task/RegistryLockManager.java: ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.registry.mysql.task; + +import static com.google.common.base.Preconditions.checkNotNull; + +import org.apache.dolphinscheduler.common.thread.ThreadUtils; +import org.apache.dolphinscheduler.plugin.registry.mysql.MysqlOperator; +import org.apache.dolphinscheduler.plugin.registry.mysql.MysqlRegistryConstant; +import org.apache.dolphinscheduler.plugin.registry.mysql.model.MysqlRegistryLock; +import org.apache.dolphinscheduler.registry.api.RegistryException; + +import java.sql.SQLException; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.util.concurrent.ThreadFactoryBuilder; + +public class RegistryLockManager implements AutoCloseable { + + private static final Logger logger = LoggerFactory.getLogger(RegistryLockManager.class); + + private final MysqlOperator mysqlOperator; + private final Map<String, MysqlRegistryLock> lockHoldMap; + private final ScheduledExecutorService lockTermUpdateThreadPool; + + public RegistryLockManager(MysqlOperator mysqlOperator) { + this.mysqlOperator = mysqlOperator; + mysqlOperator.clearExpireLock(); + this.lockHoldMap = new ConcurrentHashMap<>(); + this.lockTermUpdateThreadPool = Executors.newScheduledThreadPool( + 1, + new ThreadFactoryBuilder().setNameFormat("MysqlRegistryLockTermRefreshThread").setDaemon(true).build()); + } + + public void start() { + lockTermUpdateThreadPool.scheduleWithFixedDelay( + new LockTermRefreshTask(lockHoldMap, mysqlOperator), + MysqlRegistryConstant.TERM_REFRESH_INTERVAL, + MysqlRegistryConstant.TERM_REFRESH_INTERVAL, + TimeUnit.MILLISECONDS); + } + + /** + * Acquire the lock, if cannot get the lock will await. + */ + public void acquireLock(String lockKey) throws RegistryException { + // maybe we can use the computeIf absent + lockHoldMap.computeIfAbsent(lockKey, key -> { + MysqlRegistryLock mysqlRegistryLock; + try { + while ((mysqlRegistryLock = mysqlOperator.tryToAcquireLock(lockKey)) == null) { + logger.debug("Acquire the lock {} failed try again", key); + // acquire failed, wait and try again + ThreadUtils.sleep(1_000L); Review Comment: It's better to use the constant. ########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/resources/mysql_registry_init.sql: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +SET FOREIGN_KEY_CHECKS = 0; + +DROP TABLE IF EXISTS `t_ds_mysql_registry_data`; +CREATE TABLE `t_ds_mysql_registry_data` +( + `id` bigint(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key', + `key` varchar(200) NOT NULL COMMENT 'key, like zookeeper node path', + `data` varchar(200) NOT NULL COMMENT 'data, like zookeeper node value', + `type` tinyint(4) NOT NULL COMMENT '1: ephemeral node, 2: persistent node', + `lastUpdateTime` timestamp NULL COMMENT 'last update time', + `createTime` timestamp NULL COMMENT 'create time', + PRIMARY KEY (`id`), + unique (`key`) +) ENGINE = InnoDB + DEFAULT CHARSET = utf8; + + +DROP TABLE IF EXISTS `t_ds_mysql_registry_lock`; +CREATE TABLE `t_ds_mysql_registry_lock` Review Comment: should we add the lock owner to avoid deleting lock by mistake? ########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/java/org/apache/dolphinscheduler/plugin/registry/mysql/task/EphemeralDateManager.java: ########## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.registry.mysql.task; + +import static com.google.common.base.Preconditions.checkNotNull; + +import org.apache.dolphinscheduler.plugin.registry.mysql.MysqlOperator; +import org.apache.dolphinscheduler.plugin.registry.mysql.MysqlRegistryConstant; +import org.apache.dolphinscheduler.registry.api.ConnectionListener; +import org.apache.dolphinscheduler.registry.api.ConnectionState; + +import java.sql.SQLException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.util.concurrent.ThreadFactoryBuilder; + +/** + * This thread is used to check the connect state to mysql. + */ +public class EphemeralDateManager implements AutoCloseable { + + private static final Logger LOGGER = LoggerFactory.getLogger(EphemeralDateManager.class); + + private final MysqlOperator mysqlOperator; + private final List<ConnectionListener> connectionListeners = Collections.synchronizedList(new ArrayList<>()); + private final Set<Long> ephemeralDateIds = Collections.synchronizedSet(new HashSet<>()); + private final ScheduledExecutorService scheduledExecutorService; + + public EphemeralDateManager(MysqlOperator mysqlOperator) { + this.mysqlOperator = checkNotNull(mysqlOperator); + this.scheduledExecutorService = Executors.newScheduledThreadPool( + 1, + new ThreadFactoryBuilder().setNameFormat("EphemeralDateTermRefreshThread").setDaemon(true).build()); + mysqlOperator.clearExpireEphemeralDate(); + } + + public void start() { + this.scheduledExecutorService.scheduleWithFixedDelay( + new EphemeralDateTermRefreshTask(mysqlOperator, connectionListeners, ephemeralDateIds), + MysqlRegistryConstant.TERM_REFRESH_INTERVAL, + MysqlRegistryConstant.TERM_REFRESH_INTERVAL, + TimeUnit.MILLISECONDS); + } + + public void addConnectionListener(ConnectionListener connectionListener) { + connectionListeners.add(connectionListener); + } + + public void addEphemeralDateId(Long ephemeralDateId) { + ephemeralDateIds.add(ephemeralDateId); + } + + @Override + public void close() throws SQLException { + ephemeralDateIds.clear(); + connectionListeners.clear(); + scheduledExecutorService.shutdownNow(); + for (Long ephemeralDateId : ephemeralDateIds) { + mysqlOperator.deleteEphemeralData(ephemeralDateId); + } + } + + // Use this task to refresh ephemeral term and check the connect state. + private static class EphemeralDateTermRefreshTask implements Runnable { + private final List<ConnectionListener> connectionListeners; + private final Set<Long> ephemeralDateIds; + private final MysqlOperator mysqlOperator; + private ConnectionState connectionState; + + public EphemeralDateTermRefreshTask(MysqlOperator mysqlOperator, + List<ConnectionListener> connectionListeners, + Set<Long> ephemeralDateIds) { + this.mysqlOperator = checkNotNull(mysqlOperator); + this.connectionListeners = checkNotNull(connectionListeners); + this.ephemeralDateIds = checkNotNull(ephemeralDateIds); + } + + @Override + public void run() { + try { + ConnectionState currentConnectionState = getConnectionState(); + if (currentConnectionState == connectionState) { + // no state change + return; + } + if (connectionState == null) { + // first time connect + if (currentConnectionState == ConnectionState.CONNECTED) { + connectionState = ConnectionState.CONNECTED; + triggerListener(ConnectionState.CONNECTED); + } + } else { + // already connect before + if (connectionState == ConnectionState.CONNECTED && currentConnectionState == ConnectionState.DISCONNECTED) { + connectionState = ConnectionState.DISCONNECTED; + triggerListener(ConnectionState.DISCONNECTED); + } else if (connectionState == ConnectionState.DISCONNECTED && currentConnectionState == ConnectionState.CONNECTED) { + connectionState = ConnectionState.CONNECTED; + triggerListener(ConnectionState.RECONNECTED); + } Review Comment: same here ########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/java/org/apache/dolphinscheduler/plugin/registry/mysql/task/EphemeralDateManager.java: ########## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.registry.mysql.task; + +import static com.google.common.base.Preconditions.checkNotNull; + +import org.apache.dolphinscheduler.plugin.registry.mysql.MysqlOperator; +import org.apache.dolphinscheduler.plugin.registry.mysql.MysqlRegistryConstant; +import org.apache.dolphinscheduler.registry.api.ConnectionListener; +import org.apache.dolphinscheduler.registry.api.ConnectionState; + +import java.sql.SQLException; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.util.concurrent.ThreadFactoryBuilder; + +/** + * This thread is used to check the connect state to mysql. + */ +public class EphemeralDateManager implements AutoCloseable { + + private static final Logger LOGGER = LoggerFactory.getLogger(EphemeralDateManager.class); + + private final MysqlOperator mysqlOperator; + private final List<ConnectionListener> connectionListeners = Collections.synchronizedList(new ArrayList<>()); + private final Set<Long> ephemeralDateIds = Collections.synchronizedSet(new HashSet<>()); + private final ScheduledExecutorService scheduledExecutorService; + + public EphemeralDateManager(MysqlOperator mysqlOperator) { + this.mysqlOperator = checkNotNull(mysqlOperator); + this.scheduledExecutorService = Executors.newScheduledThreadPool( + 1, + new ThreadFactoryBuilder().setNameFormat("EphemeralDateTermRefreshThread").setDaemon(true).build()); + mysqlOperator.clearExpireEphemeralDate(); + } + + public void start() { + this.scheduledExecutorService.scheduleWithFixedDelay( + new EphemeralDateTermRefreshTask(mysqlOperator, connectionListeners, ephemeralDateIds), + MysqlRegistryConstant.TERM_REFRESH_INTERVAL, + MysqlRegistryConstant.TERM_REFRESH_INTERVAL, + TimeUnit.MILLISECONDS); + } + + public void addConnectionListener(ConnectionListener connectionListener) { + connectionListeners.add(connectionListener); + } + + public void addEphemeralDateId(Long ephemeralDateId) { + ephemeralDateIds.add(ephemeralDateId); + } + + @Override + public void close() throws SQLException { + ephemeralDateIds.clear(); + connectionListeners.clear(); + scheduledExecutorService.shutdownNow(); + for (Long ephemeralDateId : ephemeralDateIds) { + mysqlOperator.deleteEphemeralData(ephemeralDateId); + } + } + + // Use this task to refresh ephemeral term and check the connect state. + private static class EphemeralDateTermRefreshTask implements Runnable { + private final List<ConnectionListener> connectionListeners; + private final Set<Long> ephemeralDateIds; + private final MysqlOperator mysqlOperator; + private ConnectionState connectionState; + + public EphemeralDateTermRefreshTask(MysqlOperator mysqlOperator, + List<ConnectionListener> connectionListeners, + Set<Long> ephemeralDateIds) { + this.mysqlOperator = checkNotNull(mysqlOperator); + this.connectionListeners = checkNotNull(connectionListeners); + this.ephemeralDateIds = checkNotNull(ephemeralDateIds); + } + + @Override + public void run() { + try { + ConnectionState currentConnectionState = getConnectionState(); + if (currentConnectionState == connectionState) { + // no state change + return; + } + if (connectionState == null) { + // first time connect + if (currentConnectionState == ConnectionState.CONNECTED) { + connectionState = ConnectionState.CONNECTED; + triggerListener(ConnectionState.CONNECTED); + } Review Comment: Should it add some else logic if `currentConnectState != ConnectionState.CONNECTED`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
