kezhenxu94 commented on code in PR #10406: URL: https://github.com/apache/dolphinscheduler/pull/10406#discussion_r894985607
########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/resources/mysql_registry_init.sql: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +SET FOREIGN_KEY_CHECKS = 0; + +DROP TABLE IF EXISTS `t_ds_mysql_registry_data`; +CREATE TABLE `t_ds_mysql_registry_data` +( + `id` bigint(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key', + `key` varchar(200) NOT NULL COMMENT 'key, like zookeeper node path', + `data` varchar(200) NOT NULL COMMENT 'data, like zookeeper node value', + `type` tinyint(4) NOT NULL COMMENT '1: ephemeral node, 2: persistent node', + `lastUpdateTime` timestamp NULL COMMENT 'last update time', + `createTime` timestamp NULL COMMENT 'create time', + PRIMARY KEY (`id`), + unique (`key`) +) ENGINE = InnoDB + DEFAULT CHARSET = utf8; + + +DROP TABLE IF EXISTS `t_ds_mysql_registry_lock`; +CREATE TABLE `t_ds_mysql_registry_lock` Review Comment: > The host can represent the lock owner. This is dangerous when users deploy multiple components in a single machine/host, like pseudo cluster mode, you at least need to add process id to the owner key? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
