ruanwenjun commented on code in PR #10406: URL: https://github.com/apache/dolphinscheduler/pull/10406#discussion_r894984799
########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/java/org/apache/dolphinscheduler/plugin/registry/mysql/task/RegistryLockManager.java: ########## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.registry.mysql.task; + +import static com.google.common.base.Preconditions.checkNotNull; + +import org.apache.dolphinscheduler.common.thread.ThreadUtils; +import org.apache.dolphinscheduler.plugin.registry.mysql.MysqlOperator; +import org.apache.dolphinscheduler.plugin.registry.mysql.MysqlRegistryConstant; +import org.apache.dolphinscheduler.plugin.registry.mysql.model.MysqlRegistryLock; +import org.apache.dolphinscheduler.registry.api.RegistryException; + +import java.sql.SQLException; +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeUnit; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.util.concurrent.ThreadFactoryBuilder; + +public class RegistryLockManager implements AutoCloseable { + + private static final Logger logger = LoggerFactory.getLogger(RegistryLockManager.class); + + private final MysqlOperator mysqlOperator; + private final Map<String, MysqlRegistryLock> lockHoldMap; + private final ScheduledExecutorService lockTermUpdateThreadPool; + + public RegistryLockManager(MysqlOperator mysqlOperator) { + this.mysqlOperator = mysqlOperator; + mysqlOperator.clearExpireLock(); + this.lockHoldMap = new ConcurrentHashMap<>(); + this.lockTermUpdateThreadPool = Executors.newScheduledThreadPool( + 1, + new ThreadFactoryBuilder().setNameFormat("MysqlRegistryLockTermRefreshThread").setDaemon(true).build()); + } + + public void start() { + lockTermUpdateThreadPool.scheduleWithFixedDelay( + new LockTermRefreshTask(lockHoldMap, mysqlOperator), + MysqlRegistryConstant.TERM_REFRESH_INTERVAL, + MysqlRegistryConstant.TERM_REFRESH_INTERVAL, + TimeUnit.MILLISECONDS); + } + + /** + * Acquire the lock, if cannot get the lock will await. + */ + public void acquireLock(String lockKey) throws RegistryException { + // maybe we can use the computeIf absent + lockHoldMap.computeIfAbsent(lockKey, key -> { + MysqlRegistryLock mysqlRegistryLock; + try { + while ((mysqlRegistryLock = mysqlOperator.tryToAcquireLock(lockKey)) == null) { + logger.debug("Acquire the lock {} failed try again", key); + // acquire failed, wait and try again + ThreadUtils.sleep(1_000L); + } + } catch (SQLException e) { + throw new RegistryException("Acquire the lock error", e); + } + return mysqlRegistryLock; + }); + } + + public void releaseLock(String lockKey) { + MysqlRegistryLock mysqlRegistryLock = lockHoldMap.get(lockKey); + if (mysqlRegistryLock != null) { + try { + // the lock is unExit + mysqlOperator.releaseLock(mysqlRegistryLock.getId()); + lockHoldMap.remove(lockKey); + } catch (SQLException e) { + throw new RegistryException(String.format("Release lock: %s error", lockKey), e); + } + } + } + + @Override + public void close() { + lockTermUpdateThreadPool.shutdownNow(); + for (Map.Entry<String, MysqlRegistryLock> lockEntry : lockHoldMap.entrySet()) { + releaseLock(lockEntry.getKey()); + } + } + + /** + * This task is used to refresh the lock held by the current server. + */ + static class LockTermRefreshTask implements Runnable { + private final Map<String, MysqlRegistryLock> lockHoldMap; + private final MysqlOperator mysqlOperator; + + private LockTermRefreshTask(Map<String, MysqlRegistryLock> lockHoldMap, MysqlOperator mysqlOperator) { + this.lockHoldMap = checkNotNull(lockHoldMap); + this.mysqlOperator = checkNotNull(mysqlOperator); + } + Review Comment: Done. ########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/resources/mysql_registry_init.sql: ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. +*/ + +SET FOREIGN_KEY_CHECKS = 0; + +DROP TABLE IF EXISTS `t_ds_mysql_registry_data`; +CREATE TABLE `t_ds_mysql_registry_data` +( + `id` bigint(11) NOT NULL AUTO_INCREMENT COMMENT 'primary key', + `key` varchar(200) NOT NULL COMMENT 'key, like zookeeper node path', + `data` varchar(200) NOT NULL COMMENT 'data, like zookeeper node value', + `type` tinyint(4) NOT NULL COMMENT '1: ephemeral node, 2: persistent node', + `lastUpdateTime` timestamp NULL COMMENT 'last update time', + `createTime` timestamp NULL COMMENT 'create time', Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
