kezhenxu94 commented on code in PR #10406: URL: https://github.com/apache/dolphinscheduler/pull/10406#discussion_r894987111
########## dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-mysql/src/main/java/org/apache/dolphinscheduler/plugin/registry/mysql/MysqlRegistryProperties.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.registry.mysql; + +import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Configuration; + +import lombok.Data; + +@Data +@Configuration +@ConditionalOnProperty(prefix = "registry", name = "type", havingValue = "mysql") +@ConfigurationProperties(prefix = "registry") +public class MysqlRegistryProperties { + + /** + * Used to schedule refresh the ephemeral data/ lock. + */ + private long termRefreshInterval = MysqlRegistryConstant.TERM_REFRESH_INTERVAL; + /** + * Used to calculate the expire time, + * e.g. if you set 2, and latest two refresh error, then the ephemeral data/lock will be expire. + */ + private int termExpireTimes = MysqlRegistryConstant.TERM_EXPIRE_TIMES; + private MysqlDatasourceProperties mysqlDatasource; Review Comment: What about simply using `HikariConfig` so we don't need to copy over the properties again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
