EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r945076546
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
@kezhenxu94
https://github.com/diffplug/spotless/issues/649#issuecomment-662739583 It is
hardly possible for `Spotless` to replace with `wildcards` with `specific
imports`, thus this is some kind of workaround actually. To prevent developers
from pushing the commits without knowing that `wildcards` has been removed by
their pre-commit hook, one possible solution is to add a message in pre-commit
hook to inform them of this behavior. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
