kezhenxu94 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r946263982
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
> > This removes the star import. But will it instead replaces the star
import with the used specific class import? If not, this will cause compiling
failed. Can you change a class with this example?
>
> @kezhenxu94 Just a follow-up, as I've tested it locally, if we use `mvn
spotless:check` instead of `mvn spotless:apply`, it only blocks the `wildcard
imports` without removing them. To improve, we could change the pre-commit hook
from `mvn spotless:apply` to `mvn spotless:check` and add an output message to
inform contributors that they should remove `wildcard imports`. WDYT?
Can you identify the failure of `spotless:check` is because of `wildcard
imports` or other code style issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
