EricGao888 commented on code in PR #11458:
URL: https://github.com/apache/dolphinscheduler/pull/11458#discussion_r946267701
##########
pom.xml:
##########
@@ -648,13 +648,22 @@
<eclipse>
<file>style/spotless_dolphinscheduler_formatter.xml</file>
</eclipse>
+ <removeUnusedImports />
+ <importOrder>
+ <file>style/eclipse.importorder</file>
+ </importOrder>
+ <replaceRegex>
Review Comment:
> > @kezhenxu94 Yes, I just double-checked it. To reproduce, you might change
> >
https://github.com/apache/dolphinscheduler/blob/68316f68fa9b90560846c3a12274edec2bf5d960/dolphinscheduler-task-plugin/dolphinscheduler-task-zeppelin/src/main/java/org/apache/dolphinscheduler/plugin/task/zeppelin/ZeppelinTask.java#L33-L35
> >
> > to `import java.util.*;` and run `mvn spotless:check`.
>
> How can yo tell the `spotless:check` failure is because of wildcard
import, if I have other code style issues and no wildcard import?
Good question, since each rule has its name, I think there might be a way to
configure `Spotless` to explicitly tell which rule the code fails. I will take
a look and see if there is a way to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
