DarkAssassinator commented on code in PR #12980:
URL:
https://github.com/apache/dolphinscheduler/pull/12980#discussion_r1031019955
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java:
##########
@@ -382,10 +366,8 @@ public synchronized void
addWorkerInfoChangeListener(WorkerInfoChangeListener li
}
private void notifyWorkerInfoChangeListeners() {
- Map<String, Set<String>> workerGroupNodes = getWorkerGroupNodes();
- Map<String, WorkerHeartBeat> workerNodeInfo = getWorkerNodeInfo();
for (WorkerInfoChangeListener listener : workerInfoChangeListeners) {
- listener.notify(workerGroupNodes, workerNodeInfo);
+ listener.notify(getWorkerGroupNodes(), getWorkerNodeInfo());
Review Comment:
ohh, my mistake. This is a loop, my original intention is to remove the
fields that have the same name as the fields defined above. I will rollback it
and rename these two fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
