DarkAssassinator commented on code in PR #12980:
URL:
https://github.com/apache/dolphinscheduler/pull/12980#discussion_r1031022659
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java:
##########
@@ -153,29 +153,15 @@ class WorkerNodeInfoAndGroupDbSyncTask implements
Runnable {
@Override
public void run() {
try {
-
// sync worker node info
updateWorkerNodes();
updateWorkerGroupMappings();
- notifyWorkerInfoChangeListeners();
Review Comment:
> Why you remove this? this is used to notifier the `LowerWeightHostManager`
Because `updateWorkerGroupMapping` has notify(has invoke
`notifyWorkerInfoChangeListener`). So we do not need to repeat it a second time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
