[GitHub] [dolphinscheduler] DarkAssassinator commented on a diff in pull request #12980: [Improvement-12907]adjust log level and refactor private methods.

Thu, 24 Nov 2022 06:01:12 -0800 


DarkAssassinator commented on code in PR #12980:
URL: 
https://github.com/apache/dolphinscheduler/pull/12980#discussion_r1031544865


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/registry/ServerNodeManager.java:
##########
@@ -153,29 +153,15 @@ class WorkerNodeInfoAndGroupDbSyncTask implements 
Runnable {
         @Override
         public void run() {
             try {
-
                 // sync worker node info
                 updateWorkerNodes();
                 updateWorkerGroupMappings();
-                notifyWorkerInfoChangeListeners();

Review Comment:
   > It's better to remove the method in `updateWorkerGroupMappings`
   
   but others also will invoke `updateWorkerGroupMappings`, such as spring bean 
init. May `notifyWorkerInfoChangeListener` keep in `updateWorkerGroupMappings` 
should be more clear. WDYT.
   
![image](https://user-images.githubusercontent.com/20518339/203802201-418c5cfb-1d29-4eab-93c1-4499ec801513.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to