xxjingcd commented on PR #13478: URL: https://github.com/apache/dolphinscheduler/pull/13478#issuecomment-1415593309
@Radeity thanks for your code review work. >In this PR, i think you don't have to change that part of codes, it's up to users whether override hdfs configuration or not. OK, I'll remove the `todo` (about the question). > Also, you don't have to add environment configuration in dolphinscheduler_env.sh (refer to https://github.com/apache/dolphinscheduler/pull/13028). The purpose of the pr #13028 is to remove the export of `dolphinscheduler_env.sh` in the task’s initialization, so it deleted the environment configuration used in user's task. And it make a mistake, `JAVA_HOME` should not be deleted, because `JAVA_HOME` used in `dolphinscheduler-dameon.sh`. After this pr, `dolphinscheduler_env.sh` is only used by DS component (used in `dolphinscheduler-dameon.sh` ) and DS interval, not by the user’s task; And after pr #13317, the user's tasks can specify the env file config by **`shell.env_source_list`**; **That means environment file used in DS and user's task is separated now**. So I think it's no problem to do that. Or maybe I don't get what you mean? >For me, there's no problem, please update docs in resource center configuration page : OK, I'll sync the configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
