xxjingcd commented on PR #13478: URL: https://github.com/apache/dolphinscheduler/pull/13478#issuecomment-1416726744
> > So I think it's no problem to do that. Or maybe I don't get what you mean? > > We should better only add ds' internal env configuration, which we don't have now. And user/tenant manages external env configurations by themselves. `$JAVA_HOME` belongs to external configurations, we just have to declare them in the doc. That's my personal understanding of that pr, have to further make sure. cc @ruanwenjun Ok, I will remove `$JAVA_HOME` to make this pr‘s purpose simple. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
