wangbo commented on a change in pull request #1816: v2 segment support string
encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r328463227
##########
File path: be/src/olap/rowset/segment_v2/column_reader.cpp
##########
@@ -426,6 +431,20 @@ Status FileColumnIterator::_read_page(const
OrdinalPageIndexIterator& iter, Pars
RETURN_IF_ERROR(_reader->encoding_info()->create_page_decoder(data,
options, &page->data_decoder));
RETURN_IF_ERROR(page->data_decoder->init());
+ if (_reader->encoding_info()->encoding() == DICT_ENCODING) {
+ BinaryDictPageDecoder* binary_dict_page_decoder =
(BinaryDictPageDecoder*)page->data_decoder;
+ if (binary_dict_page_decoder->is_dict_encoding()) {
+ if (_dict_decoder == nullptr) {
Review comment:
for high cardinality column,dict encoding will fallback to plain
encoding,its data will contain both encoding, so I think loading dict after
data page init and knows the real encoding is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
