wangbo commented on a change in pull request #1816: v2 segment support string
encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r328525417
##########
File path: be/src/olap/rowset/segment_v2/encoding_info.cpp
##########
@@ -67,6 +68,18 @@ struct TypeEncodingTraits<type, RLE> {
}
};
+template<FieldType type>
+struct TypeEncodingTraits<type, DICT_ENCODING> {
+ static Status create_page_builder(const PageBuilderOptions& opts,
PageBuilder** builder) {
+ *builder = new BinaryDictPageBuilder(opts);
+ return Status::OK();
Review comment:
agree ,it seems that there is no RETURN_IF_ERROR logic in class constructor;
And I think it's better to make a new commit to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
