wangbo commented on a change in pull request #1816: v2 segment support string
encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r329349321
##########
File path: be/src/olap/field.h
##########
@@ -57,6 +57,7 @@ class Field {
inline void set_to_max(char* buf) const { return
_type_info->set_to_max(buf); }
inline void set_to_min(char* buf) const { return
_type_info->set_to_min(buf); }
+ inline char* get_type_value_with_arena(Arena* arena) const { return
_type_info->get_type_value_with_arena(arena); }
Review comment:
Field defines column's content info,TypeInfo defines all type column's
behavior;
In column_zone_map_builder,caller just need to care column abstract
behavior,but not to known its realization.Different type has different
realization.
Such as,when calling get_type_value_with_arena,int/double type not need data
length,while string type need data length,so int/double type and char type has
different method.
I think using Field class(we already have CharField and VarcharField) to
realize polymorphism is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
