wangbo commented on a change in pull request #1816: v2 segment support string
encode(#1766)
URL: https://github.com/apache/incubator-doris/pull/1816#discussion_r329405674
##########
File path: be/src/olap/types.h
##########
@@ -568,6 +577,13 @@ struct FieldTypeTraits<OLAP_FIELD_TYPE_CHAR> : public
BaseFieldtypeTraits<OLAP_F
auto slice = reinterpret_cast<const Slice*>(data);
return HashUtil::hash(slice->data, slice->size, seed);
}
+ static char* allocate_value_from_arena(Arena* arena) {
Review comment:
agree;Field.h can decide allocate type value whether with size or not, but
now ColumnZoneMapBuilder's field doesn't contains whole column info;
I think we can init a Field in SegmentWriter.init ,and then transfer the
field to ColumnWriter and ColumnZonemap to instead of TypeInfo, but this need
to change ColumnWriter constructor and ColumnZonemap, and change corresponding
UT
So I prepare to submit another pr to fix the problem that string's
ColumnZoneMap's max/min value init with real length.
Currently we first use fixed length.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
