imay commented on a change in pull request #2630: Support bitmap index for more
type
URL: https://github.com/apache/incubator-doris/pull/2630#discussion_r365112842
##########
File path: be/src/util/frame_of_reference_coding.cpp
##########
@@ -25,10 +25,32 @@
namespace doris {
-static inline uint8_t bits(const uint64_t v) {
+
+static inline uint8_t bits_less_than_64(const uint64_t v) {
return v == 0 ? 0 : 64 - __builtin_clzll(v);
}
+static inline uint8_t bits_may_more_than_64(const uint128_t v) {
+ uint64_t hi = v >> 64;
+ uint64_t lo = v;
+ int z[3]={
+ __builtin_clzll(hi),
+ __builtin_clzll(lo) + 64,
+ 128
+ };
+ int idx = !hi + ((!lo)&(!hi));
Review comment:
```suggestion
int idx = !hi + ((!lo) & (!hi));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
