kangkaisen commented on a change in pull request #2630: Support bitmap index
for more type
URL: https://github.com/apache/incubator-doris/pull/2630#discussion_r366303831
##########
File path: be/src/util/frame_of_reference_coding.cpp
##########
@@ -109,13 +131,20 @@ void ForEncoder<T>::bit_packing_one_frame_value(const T*
input) {
T max = input[0];
bool is_ascending = true;
uint8_t bit_width = 0;
+ T half_max_delta = numeric_limits_max() >> 1;
+ bool save_original_value = false;
Review comment:
is_keep_original_value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
