kangkaisen commented on a change in pull request #2630: Support bitmap index
for more type
URL: https://github.com/apache/incubator-doris/pull/2630#discussion_r366310190
##########
File path: be/src/util/frame_of_reference_coding.h
##########
@@ -37,16 +41,23 @@ namespace doris {
// 1. Body:
// BitPackingFrame * FrameCount
// 2. Footer:
-// (2 bit OrderFlag + 6 bit BitWidth) * FrameCount
+//
+// (8 bit OrderFlag + 8 bit BitWidth) * FrameCount
// 8 bit FrameValueNum
// 32 bit ValuesNum
//
-// The not ascending order BitPackingFrame format:
-// MinValue, (Value - MinVale) * FrameValueNum
+// if the OrderFlag & 2 == 2: save original values
Review comment:
> why not comment as
>
> OrderFlag
> case 2:
> case 1:
> case 0:
+1. which is more clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
