github-actions[bot] commented on code in PR #24793:
URL: https://github.com/apache/doris/pull/24793#discussion_r1334148780
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -559,7 +577,7 @@ class DataSinkOperatorX : public DataSinkOperatorXBase {
: DataSinkOperatorXBase(id, sources) {}
~DataSinkOperatorX() override = default;
- Status setup_local_state(RuntimeState* state, LocalSinkStateInfo& info)
override;
+ virtual Status setup_local_state(RuntimeState* state, LocalSinkStateInfo&
info) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status setup_local_state(RuntimeState* state, LocalSinkStateInfo& info)
override;
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -599,7 +617,11 @@
virtual Status open(RuntimeState* state) override { return Status::OK(); }
- Status close(RuntimeState* state) override {
+ virtual Status try_close(RuntimeState* state, Status exec_status) override
{
+ return Status::OK();
+ }
+
+ virtual Status close(RuntimeState* state, Status exec_status) override {
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status close(RuntimeState* state, Status exec_status) override {
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -599,7 +617,11 @@
virtual Status open(RuntimeState* state) override { return Status::OK(); }
- Status close(RuntimeState* state) override {
+ virtual Status try_close(RuntimeState* state, Status exec_status) override
{
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status try_close(RuntimeState* state, Status exec_status) override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
