github-actions[bot] commented on code in PR #24793:
URL: https://github.com/apache/doris/pull/24793#discussion_r1334245784
##########
be/src/pipeline/exec/result_file_sink_operator.h:
##########
@@ -42,5 +43,76 @@ class ResultFileSinkOperator final : public
DataSinkOperator<ResultFileSinkOpera
bool can_write() override { return true; }
};
+class ResultFileSinkOperatorX;
+class ResultSinkLocalState;
+class ResultFileSinkLocalState final : public
AsyncWriterSink<vectorized::VFileResultWriter> {
+public:
+ using Base = AsyncWriterSink<vectorized::VFileResultWriter>;
+ ENABLE_FACTORY_CREATOR(ResultFileSinkLocalState);
+ ResultFileSinkLocalState(DataSinkOperatorXBase* parent, RuntimeState*
state);
+
+ Status init(RuntimeState* state, LocalSinkStateInfo& info) override;
+ Status open(RuntimeState* state) override;
+ Status close(RuntimeState* state, Status exec_status) override;
+
+ int sender_id() const { return _sender_id; }
Review Comment:
warning: function 'sender_id' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] int sender_id() const { return _sender_id; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
