github-actions[bot] commented on code in PR #24793:
URL: https://github.com/apache/doris/pull/24793#discussion_r1334160362
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -217,7 +218,7 @@ class OperatorXBase : public OperatorBase {
virtual bool runtime_filters_are_ready_or_timeout(RuntimeState* state)
const { return true; }
- virtual Status close(RuntimeState* state) override;
+ Status close(RuntimeState* state) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status close(RuntimeState* state) override;
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -318,7 +319,7 @@ class PipelineXLocalState : public PipelineXLocalStateBase {
: PipelineXLocalStateBase(state, parent) {}
virtual ~PipelineXLocalState() {}
- virtual Status init(RuntimeState* state, LocalStateInfo& info) override {
+ Status init(RuntimeState* state, LocalStateInfo& info) override {
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status init(RuntimeState* state, LocalStateInfo& info) override {
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -358,7 +359,7 @@ class PipelineXLocalState : public PipelineXLocalStateBase {
return Status::OK();
}
- virtual Status close(RuntimeState* state) override {
+ Status close(RuntimeState* state) override {
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status close(RuntimeState* state) override {
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -597,9 +613,11 @@ class PipelineXSinkLocalState : public
PipelineXSinkLocalStateBase {
return Status::OK();
}
- virtual Status open(RuntimeState* state) override { return Status::OK(); }
+ Status open(RuntimeState* state) override { return Status::OK(); }
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status open(RuntimeState* state) override { return Status::OK(); }
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -456,12 +458,15 @@ class DataSinkOperatorXBase : public OperatorBase {
DataSinkOperatorXBase(const int id, std::vector<int>& sources)
: OperatorBase(nullptr), _id(id), _dests_id(sources) {}
- virtual ~DataSinkOperatorXBase() override = default;
+ ~DataSinkOperatorXBase() override = default;
// For agg/sort/join sink.
virtual Status init(const TPlanNode& tnode, RuntimeState* state);
- virtual Status init(const TDataSink& tsink) override;
+ Status init(const TDataSink& tsink) override;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status init(const TDataSink& tsink) override;
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -456,12 +458,15 @@ class DataSinkOperatorXBase : public OperatorBase {
DataSinkOperatorXBase(const int id, std::vector<int>& sources)
: OperatorBase(nullptr), _id(id), _dests_id(sources) {}
- virtual ~DataSinkOperatorXBase() override = default;
+ ~DataSinkOperatorXBase() override = default;
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
~DataSinkOperatorXBase() override = default;
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -373,7 +374,7 @@ class PipelineXLocalState : public PipelineXLocalStateBase {
return Status::OK();
}
- virtual std::string debug_string(int indentation_level = 0) const override;
+ std::string debug_string(int indentation_level = 0) const override;
Review Comment:
warning: function 'debug_string' should be marked [[nodiscard]]
[modernize-use-nodiscard]
```suggestion
[[nodiscard]] virtual std::string debug_string(int indentation_level =
0) const override;
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -261,11 +262,11 @@ class OperatorXBase : public OperatorBase {
[[nodiscard]] int64_t limit() const { return _limit; }
- [[nodiscard]] virtual const RowDescriptor& row_desc() override {
+ [[nodiscard]] const RowDescriptor& row_desc() override {
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
[[nodiscard]] const RowDescriptor& row_desc() override {
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -577,7 +593,7 @@ class PipelineXSinkLocalState : public
PipelineXSinkLocalStateBase {
: PipelineXSinkLocalStateBase(parent, state) {}
~PipelineXSinkLocalState() override = default;
- virtual Status init(RuntimeState* state, LocalSinkStateInfo& info)
override {
+ Status init(RuntimeState* state, LocalSinkStateInfo& info) override {
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status init(RuntimeState* state, LocalSinkStateInfo& info) override {
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -261,11 +262,11 @@ class OperatorXBase : public OperatorBase {
[[nodiscard]] int64_t limit() const { return _limit; }
- [[nodiscard]] virtual const RowDescriptor& row_desc() override {
+ [[nodiscard]] const RowDescriptor& row_desc() override {
return _output_row_descriptor ? *_output_row_descriptor :
_row_descriptor;
}
- [[nodiscard]] virtual bool is_source() const override { return false; }
+ [[nodiscard]] bool is_source() const override { return false; }
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
[[nodiscard]] bool is_source() const override { return false; }
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -597,9 +613,11 @@ class PipelineXSinkLocalState : public
PipelineXSinkLocalStateBase {
return Status::OK();
}
- virtual Status open(RuntimeState* state) override { return Status::OK(); }
+ Status open(RuntimeState* state) override { return Status::OK(); }
- Status close(RuntimeState* state) override {
+ Status try_close(RuntimeState* state, Status exec_status) override {
return Status::OK(); }
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Status try_close(RuntimeState* state, Status exec_status) override {
```
##########
be/src/pipeline/pipeline_x/operator.h:
##########
@@ -386,7 +387,7 @@ class PipelineXSinkLocalStateBase {
public:
PipelineXSinkLocalStateBase(DataSinkOperatorXBase* parent_, RuntimeState*
state_)
: _parent(parent_), _state(state_) {}
- virtual ~PipelineXSinkLocalStateBase() {}
+ virtual ~PipelineXSinkLocalStateBase() = default;
Review Comment:
warning: use '= default' to define a trivial destructor
[modernize-use-equals-default]
```suggestion
virtual ~PipelineXSinkLocalStateBase() = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
