JNSimba commented on code in PR #272:
URL:
https://github.com/apache/doris-flink-connector/pull/272#discussion_r1426765730
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/deserialization/DorisJsonDebeziumDeserializationSchema.java:
##########
@@ -63,7 +64,9 @@ public void deserialize(SourceRecord sourceRecord,
Collector<String> collector)
private JsonNode convertToJson(Schema schema, Object value) throws
DorisException {
if (value == null) {
- if (schema == null) // Any schema is valid and we don't have a
default, so treat this as an optional schema
+ if (schema
+ == null) // Any schema is valid and we don't have a
default, so treat this as an
+ // optional schema
Review Comment:
It feels a bit strange, or put the comment above the if?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
