JNSimba commented on code in PR #272:
URL:
https://github.com/apache/doris-flink-connector/pull/272#discussion_r1426793711
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDateConverter.java:
##########
@@ -105,28 +116,32 @@ private String convertStringTimestamp(String data) {
final Matcher toTimestampMatcher = TO_TIMESTAMP.matcher(data);
if (toTimestampMatcher.matches()) {
String dateText = toTimestampMatcher.group(1);
- dateTime =
LocalDateTime.from(TIMESTAMP_FORMATTER.parse(completeMilliseconds(dateText.trim())));
+ dateTime =
+ LocalDateTime.from(
+
TIMESTAMP_FORMATTER.parse(completeMilliseconds(dateText.trim())));
return
dateTimeV2Formatter.format(dateTime.atZone(timestampZoneId));
}
final Matcher toDateMatcher = TO_DATE.matcher(data);
if (toDateMatcher.matches()) {
String date = toDateMatcher.group(1);
- dateTime =
LocalDateTime.from(TIMESTAMP_FORMATTER.parse(completeMilliseconds(date.trim())));
+ dateTime =
+ LocalDateTime.from(
+
TIMESTAMP_FORMATTER.parse(completeMilliseconds(date.trim())));
return
dateTimeV2Formatter.format(dateTime.atZone(timestampZoneId));
}
return null;
}
private String completeMilliseconds(String stringValue) {
- if(stringValue.length() == DATETIMEV2_PATTERN.length()){
+ if (stringValue.length() == datetimeV2Pattern.length()) {
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
