JNSimba commented on code in PR #272:
URL:
https://github.com/apache/doris-flink-connector/pull/272#discussion_r1426793375
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDateConverter.java:
##########
@@ -36,66 +37,76 @@
public class OracleDateConverter implements CustomConverter<SchemaBuilder,
RelationalColumn> {
private static final Logger log =
LoggerFactory.getLogger(OracleDateConverter.class);
- private static final Pattern TO_DATE = Pattern.compile("TO_DATE\\('(.*)',[
]*'(.*)'\\)", Pattern.CASE_INSENSITIVE);
- private static final Pattern TO_TIMESTAMP =
Pattern.compile("TO_TIMESTAMP\\('(.*)'\\)", Pattern.CASE_INSENSITIVE);
- private static final Pattern TIMESTAMP_OR_DATE_REGEX =
Pattern.compile("^TIMESTAMP[(]\\d[)]$|^DATE$", Pattern.CASE_INSENSITIVE);
+ private static final Pattern TO_DATE =
+ Pattern.compile("TO_DATE\\('(.*)',[ ]*'(.*)'\\)",
Pattern.CASE_INSENSITIVE);
+ private static final Pattern TO_TIMESTAMP =
+ Pattern.compile("TO_TIMESTAMP\\('(.*)'\\)",
Pattern.CASE_INSENSITIVE);
+ private static final Pattern TIMESTAMP_OR_DATE_REGEX =
+ Pattern.compile("^TIMESTAMP[(]\\d[)]$|^DATE$",
Pattern.CASE_INSENSITIVE);
private ZoneId timestampZoneId = ZoneId.systemDefault();
- public static Properties DEFAULT_PROPS = new Properties();
- private final String DATETIME_PATTERN = "yyyy-MM-dd HH:mm:ss";
- private final String DATETIMEV2_PATTERN = "yyyy-MM-dd HH:mm:ss.SSSSSS";
- private final DateTimeFormatter dateTimeV2Formatter =
DateTimeFormatter.ofPattern(DATETIMEV2_PATTERN);
+ public static Properties defaultProps = new Properties();
+ private final String datetimePattern = "yyyy-MM-dd HH:mm:ss";
Review Comment:
static final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
