DongLiang-0 commented on code in PR #272:
URL:
https://github.com/apache/doris-flink-connector/pull/272#discussion_r1427492860
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/mysql/DateToStringConverter.java:
##########
@@ -43,23 +43,28 @@ public class DateToStringConverter implements
CustomConverter<SchemaBuilder, Rel
private DateTimeFormatter timestampFormatter =
DateTimeFormatter.ISO_DATE_TIME;
private ZoneId timestampZoneId = ZoneId.systemDefault();
- public static Properties DEFAULT_PROPS = new Properties();
+ public static Properties defaultProps = new Properties();
Review Comment:
That's a good idea.
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/DorisStreamLoad.java:
##########
@@ -143,7 +157,8 @@ public void abortPreCommit(String labelSuffix, long chkID)
throws Exception {
LOG.info("abort for labelSuffix {}. start chkId {}.", labelSuffix,
chkID);
while (true) {
try {
- // TODO: According to label abort txn. Currently, it can only
be aborted based on txnid,
+ // TODO: According to label abort txn. Currently, it can only
be aborted based on
+ // txnid,
Review Comment:
sure
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/deserialization/DorisJsonDebeziumDeserializationSchema.java:
##########
@@ -63,7 +64,9 @@ public void deserialize(SourceRecord sourceRecord,
Collector<String> collector)
private JsonNode convertToJson(Schema schema, Object value) throws
DorisException {
if (value == null) {
- if (schema == null) // Any schema is valid and we don't have a
default, so treat this as an optional schema
+ if (schema
+ == null) // Any schema is valid and we don't have a
default, so treat this as an
+ // optional schema
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
