DongLiang-0 commented on code in PR #272:
URL:
https://github.com/apache/doris-flink-connector/pull/272#discussion_r1427495534
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/sqlserver/SqlServerDateConverter.java:
##########
@@ -34,19 +35,23 @@ public class SqlServerDateConverter implements
CustomConverter<SchemaBuilder, Re
private DateTimeFormatter dateFormatter = DateTimeFormatter.ISO_DATE;
private DateTimeFormatter timestampFormatter =
DateTimeFormatter.ISO_DATE_TIME;
- public static Properties DEFAULT_PROPS = new Properties();
+ public static Properties defaultProps = new Properties();
Review Comment:
sure
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/oracle/OracleDatabaseSync.java:
##########
@@ -128,11 +140,13 @@ public DataStreamSource<String>
buildCdcSource(StreamExecutionEnvironment env) {
Preconditions.checkNotNull(databaseName, "database-name in oracle is
required");
Preconditions.checkNotNull(schemaName, "schema-name in oracle is
required");
String tableName = config.get(OracleSourceOptions.TABLE_NAME);
- //When debezium incrementally reads, it will be judged based on
regexp_like.
- //When the regular length exceeds 512, an error will be reported, like
ORA-12733: regular expression too long
- if(tableName.length() > 384){
- //max database name length 128
- tableName = StringUtils.isNullOrWhitespaceOnly(includingTables) ?
".*" : includingTables;
+ // When debezium incrementally reads, it will be judged based on
regexp_like.
+ // When the regular length exceeds 512, an error will be reported,
like ORA-12733: regular
+ // expression too long
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
