dataroaring commented on code in PR #32980:
URL: https://github.com/apache/doris/pull/32980#discussion_r1566605801
##########
regression-test/suites/insert_p0/txn_insert.groovy:
##########
@@ -328,19 +480,44 @@ suite("txn_insert") {
where txn_insert_dt4.id = txn_insert_dt2.id;
"""
sql """
- delete from txn_insert_dt2 where id = 1 or id = 5;
+ delete from txn_insert_dt2 where id = 1;
"""
sql """
- delete from txn_insert_dt5 partition(p_20000102) where id = 1
or id = 5;
+ delete from txn_insert_dt2 where id = 5;
+ """
Review Comment:
If we do insert and delete on the same table, then there is a problem that,
if the delete is a predicate and implemented via push handler, then the delete
take effect on the insert result. while if the delete is in `delete from`
format then the delete does not take effect on the insert result.
It is ambiguous for users.
##########
regression-test/suites/insert_p0/txn_insert.groovy:
##########
@@ -328,19 +480,44 @@ suite("txn_insert") {
where txn_insert_dt4.id = txn_insert_dt2.id;
"""
sql """
- delete from txn_insert_dt2 where id = 1 or id = 5;
+ delete from txn_insert_dt2 where id = 1;
"""
sql """
- delete from txn_insert_dt5 partition(p_20000102) where id = 1
or id = 5;
+ delete from txn_insert_dt2 where id = 5;
+ """
Review Comment:
BTW, delete sign also works as delete via push handler.
##########
regression-test/suites/insert_p0/txn_insert.groovy:
##########
@@ -328,19 +480,44 @@ suite("txn_insert") {
where txn_insert_dt4.id = txn_insert_dt2.id;
"""
sql """
- delete from txn_insert_dt2 where id = 1 or id = 5;
+ delete from txn_insert_dt2 where id = 1;
"""
sql """
- delete from txn_insert_dt5 partition(p_20000102) where id = 1
or id = 5;
+ delete from txn_insert_dt2 where id = 5;
+ """
Review Comment:
Thread1 t2: insert into table1
Thread2 t1: insert into table2 select table1, t3: insert into table2 select
table1.
Is result of t2 visible to insert at t3?
##########
regression-test/suites/insert_p0/txn_insert.groovy:
##########
@@ -328,19 +480,44 @@ suite("txn_insert") {
where txn_insert_dt4.id = txn_insert_dt2.id;
"""
sql """
- delete from txn_insert_dt2 where id = 1 or id = 5;
+ delete from txn_insert_dt2 where id = 1;
"""
sql """
- delete from txn_insert_dt5 partition(p_20000102) where id = 1
or id = 5;
+ delete from txn_insert_dt2 where id = 5;
+ """
Review Comment:
If a dba changes the replication num of a table between two insert to a
table, then what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
