dataroaring commented on code in PR #32980:
URL: https://github.com/apache/doris/pull/32980#discussion_r1566617348
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionEntry.java:
##########
@@ -163,39 +162,44 @@ public void setpLoadId(Types.PUniqueId pLoadId) {
this.pLoadId = pLoadId;
}
- // Used for insert into select
- public void beginTransaction(DatabaseIf database, TableIf table)
- throws DdlException, BeginTransactionException,
MetaNotFoundException, AnalysisException,
- QuotaExceedException {
+ // Used for insert into select, return the sub_txn_id for this insert
+ public long beginTransaction(TableIf table) throws UserException {
if (isTxnBegin()) {
Review Comment:
Does isTxnBegin indicate there is already a insert into values? If so, maybe
we should change name of isTxnBegin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
