dataroaring commented on code in PR #32980:
URL: https://github.com/apache/doris/pull/32980#discussion_r1566621595
##########
fe/fe-core/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java:
##########
@@ -286,6 +303,33 @@ public boolean commitAndPublishTransaction(DatabaseIf db,
List<Table> tableList,
return dbTransactionMgr.waitForTransactionFinished(db, transactionId,
publishTimeoutMillis);
}
+ public boolean commitAndPublishTransaction(DatabaseIf db, long
transactionId,
+ List<SubTransactionState> subTransactionStates, long
timeoutMillis) throws UserException {
+ StopWatch stopWatch = new StopWatch();
+ stopWatch.start();
+ List<Table> tableList =
subTransactionStates.stream().map(SubTransactionState::getTable).distinct()
Review Comment:
Are table in tableList ordered? otherwise, deadlock may happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
