caiconghui commented on PR #9172: URL: https://github.com/apache/incubator-doris/pull/9172#issuecomment-1109829258
> `triple.getMiddle() == null ? triple.getLeft() : triple.getMiddle()` This code appears many times, can we do it in the generated place? `return Triple.of(ip, Config.enable_k8s_container_drift_mode ? hostName : ip, heartbeatPort)` whether it can be satisfied? Config.enable_k8s_container_drift_mode config is master only, replay operation no need depend on this config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
