caiconghui commented on code in PR #9172:
URL: https://github.com/apache/incubator-doris/pull/9172#discussion_r858765531
##########
fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java:
##########
@@ -1061,7 +1084,7 @@ public static Pair<String, Integer>
validateHostAndPort(String hostPort) throws
throw new AnalysisException("Port is out of range: " +
heartbeatPort);
}
- return new Pair<String, Integer>(host, heartbeatPort);
+ return Triple.of(ip, Config.enable_k8s_container_drift_mode ?
hostName : null, heartbeatPort);
Review Comment:
for broker, now we use ip as unique identifier, but in k8s environment, we
need to use hostname, so here I make hostName null if doris not in k8s
environment, or we will need to do more check for hostName is really hostName,
or it is a ip? may be more complex. so if we don't need it, just set it null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
