yiguolei commented on code in PR #9172:
URL: https://github.com/apache/incubator-doris/pull/9172#discussion_r861575405
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BrokerMgr.java:
##########
@@ -195,19 +195,19 @@ public void addBrokers(String name,
Collection<Pair<String, Integer>> addresses)
}
List<FsBroker> addedBrokerAddress = Lists.newArrayList();
- for (Pair<String, Integer> pair : addresses) {
- List<FsBroker> addressList = brokerAddrsMap.get(pair.first);
+ for (Triple<String, String, Integer> triple : addresses) {
+ List<FsBroker> addressList =
brokerAddrsMap.get(triple.getLeft());
for (FsBroker addr : addressList) {
- if (addr.port == pair.second) {
- throw new DdlException("Broker(" + pair.first + ":" +
pair.second
+ if (addr.port == triple.getRight()) {
Review Comment:
if drift mode is set, should also check hostname here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
