HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1821850017
##########
be/src/vec/data_types/serde/data_type_decimal_serde.h:
##########
@@ -134,8 +136,8 @@ class DataTypeDecimalSerDe : public DataTypeSerDe {
template <typename T>
Status DataTypeDecimalSerDe<T>::write_column_to_pb(const IColumn& column,
PValues& result,
- int start, int end) const {
- int row_count = end - start;
+ int64_t start, int64_t end)
const {
+ auto row_count = cast_set<int>(end - start);
Review Comment:
int64?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
