github-actions[bot] commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1822069374
##########
be/src/util/jsonb_writer.h:
##########
@@ -415,11 +414,11 @@ class JsonbWriterT {
if (!stack_.empty() && stack_.top().state == WS_Object && kvState_ ==
WS_Value) {
WriteInfo& ci = stack_.top();
std::streampos cur_pos = os_->tellp();
- int32_t size = (int32_t)(cur_pos - ci.sz_pos - sizeof(uint32_t));
+ int64_t size = (int64_t)(cur_pos - ci.sz_pos - sizeof(uint64_t));
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
auto size = (int64_t)(cur_pos - ci.sz_pos - sizeof(uint64_t));
```
##########
be/src/util/jsonb_writer.h:
##########
@@ -463,11 +462,11 @@ class JsonbWriterT {
if (!stack_.empty() && stack_.top().state == WS_Array && kvState_ ==
WS_Value) {
WriteInfo& ci = stack_.top();
std::streampos cur_pos = os_->tellp();
- int32_t size = (int32_t)(cur_pos - ci.sz_pos - sizeof(uint32_t));
+ int64_t size = (int64_t)(cur_pos - ci.sz_pos - sizeof(uint64_t));
Review Comment:
warning: use auto when initializing with a cast to avoid duplicating the
type name [modernize-use-auto]
```suggestion
auto size = (int64_t)(cur_pos - ci.sz_pos - sizeof(uint64_t));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
