zhangstar333 commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1822083654
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -162,7 +166,7 @@ void
DataTypeDateTimeV2SerDe::read_column_from_arrow(IColumn& column,
// convert second
v.from_unixtime(utc_epoch / divisor, ctz);
// get rest time
- v.set_microsecond(utc_epoch % divisor);
+ v.set_microsecond(cast_set<uint32_t>(utc_epoch % divisor));
Review Comment:
done
##########
be/src/vec/data_types/serde/data_type_bitmap_serde.cpp:
##########
@@ -81,12 +82,12 @@ Status DataTypeBitMapSerDe::read_column_from_pb(IColumn&
column, const PValues&
void DataTypeBitMapSerDe::write_one_cell_to_jsonb(const IColumn& column,
JsonbWriter& result,
Arena* mem_pool, int32_t
col_id,
- int row_num) const {
+ int64_t row_num) const {
auto& data_column = assert_cast<const ColumnBitmap&>(column);
- result.writeKey(col_id);
+ result.writeKey(cast_set<JsonbKeyValue::keyid_type>(col_id));
auto bitmap_value =
const_cast<BitmapValue&>(data_column.get_element(row_num));
// serialize the content of string
- auto size = bitmap_value.getSizeInBytes();
+ auto size = cast_set<uint32_t>(bitmap_value.getSizeInBytes());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
