924060929 commented on code in PR #9807:
URL: https://github.com/apache/incubator-doris/pull/9807#discussion_r884810863
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/RuleType.java:
##########
@@ -23,18 +23,22 @@
public enum RuleType {
// binding rules
BINDING_UNBOUND_RELATION_RULE,
+ BINDING_SENTINEL,
Review Comment:
We should use an enum RuleClass to avoid sentinel. e.g.
```java
enum RuleClass {
BIND_RULE, REWRITE_RULE, EXPLORATION_RULE...
}
public enum RuleType {
BINDING_UNBOUND_RELATION_RULE(BIND_RULE),
LOGICAL_JOIN_COMMUTATIVE(EXPLORATION_RULE)
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
