924060929 commented on code in PR #9807:
URL: https://github.com/apache/incubator-doris/pull/9807#discussion_r884829067
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/AbstractTreeNode.java:
##########
@@ -33,15 +36,43 @@
protected final NodeType type;
protected final List<TreeNode> children;
+ protected final GroupExpression groupExpression;
Review Comment:
Maybe we should use a `GroupPlan` to avoid TreeNode hold the GroupExpression.
e.g.
```java
class GroupPlan extends Plan {
private final Plan delegatePlan;
private final Group group;
public GroupPlan(Plan delegatePlan, Group group) {
this.delegatePlan = delegatePlan;
this.group = group;
}
public List<Plan> children() {
return delegatePlan.children();
}
public Group getGroup() {
return group;
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
