morrySnow commented on code in PR #9807:
URL: https://github.com/apache/incubator-doris/pull/9807#discussion_r885235943
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/AbstractTreeNode.java:
##########
@@ -33,15 +36,43 @@
protected final NodeType type;
protected final List<TreeNode> children;
+ protected final GroupExpression groupExpression;
+
public AbstractTreeNode(NodeType type, TreeNode... children) {
- this.type = type;
- this.children = ImmutableList.copyOf(children);
+ this(type, null, children);
}
- public AbstractTreeNode(NodeType type, List<NODE_TYPE> children) {
+ /**
+ * Constructor for plan node.
+ *
+ * @param type node type
+ * @param groupExpression group expression related to the operator of this
node
+ * @param children children of this node
+ */
+ public AbstractTreeNode(NodeType type, GroupExpression groupExpression,
TreeNode... children) {
this.type = type;
- this.children = ImmutableList.copyOf(children);
+ if (children.length != 0 && children[0] == null) {
Review Comment:
add a TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
