yiguolei commented on code in PR #54243:
URL: https://github.com/apache/doris/pull/54243#discussion_r2255775489
##########
be/src/exec/schema_scanner/schema_workload_groups_scanner.cpp:
##########
@@ -31,13 +31,13 @@ namespace doris {
std::vector<SchemaScanner::ColumnDesc>
SchemaWorkloadGroupsScanner::_s_tbls_columns = {
{"ID", TYPE_BIGINT, sizeof(int64_t), true},
{"NAME", TYPE_VARCHAR, sizeof(StringRef), true},
- {"CPU_SHARE", TYPE_BIGINT, sizeof(int64_t), true},
- {"MEMORY_LIMIT", TYPE_VARCHAR, sizeof(StringRef), true},
- {"ENABLE_MEMORY_OVERCOMMIT", TYPE_VARCHAR, sizeof(StringRef), true},
+ {"MIN_CPU_PERCENT", TYPE_BIGINT, sizeof(int64_t), true},
+ {"MAX_CPU_PERCENT", TYPE_BIGINT, sizeof(int64_t), true},
+ {"MIN_MEMORY_PERCENT", TYPE_BIGINT, sizeof(int64_t), true},
+ {"MAX_MEMORY_PERCENT", TYPE_BIGINT, sizeof(int64_t), true},
Review Comment:
I think it is ok. If the memory is very large, use do not need care about
5GB memory.
But this is a bug, the type should be varchar, not int64.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
