wangbo commented on code in PR #54243:
URL: https://github.com/apache/doris/pull/54243#discussion_r2256021426
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java:
##########
@@ -96,34 +105,34 @@ public class WorkloadGroup implements Writable,
GsonPostProcessable {
// default value is as followed
// cpu_share=1024, memory_limit=0%(0 means not limit),
enable_memory_overcommit=true
private static final ImmutableSet<String> ALL_PROPERTIES_NAME = new
ImmutableSet.Builder<String>()
-
.add(CPU_SHARE).add(MEMORY_LIMIT).add(ENABLE_MEMORY_OVERCOMMIT).add(MAX_CONCURRENCY)
-
.add(MAX_QUEUE_SIZE).add(QUEUE_TIMEOUT).add(CPU_HARD_LIMIT).add(SCAN_THREAD_NUM)
- .add(MAX_REMOTE_SCAN_THREAD_NUM).add(MIN_REMOTE_SCAN_THREAD_NUM)
- .add(MEMORY_LOW_WATERMARK).add(MEMORY_HIGH_WATERMARK)
+ .add(MAX_CPU_PERCENT).add(MIN_CPU_PERCENT)
+
.add(MAX_MEMORY_PERCENT).add(MIN_MEMORY_PERCENT).add(ENABLE_MEMORY_OVERCOMMIT)
Review Comment:
ENABLE_MEMORY_OVERCOMMIT这个是不是可以删了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
