yiguolei commented on code in PR #54243:
URL: https://github.com/apache/doris/pull/54243#discussion_r2256026842
##########
fe/fe-core/src/main/java/org/apache/doris/resource/workloadgroup/WorkloadGroup.java:
##########
@@ -96,34 +105,34 @@ public class WorkloadGroup implements Writable,
GsonPostProcessable {
// default value is as followed
// cpu_share=1024, memory_limit=0%(0 means not limit),
enable_memory_overcommit=true
private static final ImmutableSet<String> ALL_PROPERTIES_NAME = new
ImmutableSet.Builder<String>()
-
.add(CPU_SHARE).add(MEMORY_LIMIT).add(ENABLE_MEMORY_OVERCOMMIT).add(MAX_CONCURRENCY)
-
.add(MAX_QUEUE_SIZE).add(QUEUE_TIMEOUT).add(CPU_HARD_LIMIT).add(SCAN_THREAD_NUM)
- .add(MAX_REMOTE_SCAN_THREAD_NUM).add(MIN_REMOTE_SCAN_THREAD_NUM)
- .add(MEMORY_LOW_WATERMARK).add(MEMORY_HIGH_WATERMARK)
+ .add(MAX_CPU_PERCENT).add(MIN_CPU_PERCENT)
+
.add(MAX_MEMORY_PERCENT).add(MIN_MEMORY_PERCENT).add(ENABLE_MEMORY_OVERCOMMIT)
Review Comment:
还不太行，现在老版本升级过来的normal的内存只有40%，之前是软限，所以没问题。 我们现在都改成硬限了，会导致query
被cancel。所以还得让默认的enable memory overcommit 发挥作用，让他是true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
