yiguolei commented on code in PR #57702:
URL: https://github.com/apache/doris/pull/57702#discussion_r2558464710


##########
gensrc/proto/segment_v2.proto:
##########
@@ -246,6 +256,17 @@ message SegmentFooterPB {
 
     // Primary key index meta
     optional PrimaryKeyIndexMetaPB primary_key_index_meta = 10;
+
+    // Externalized ColumnMetaPB layout (optional; presence indicates v2 meta 
layout available)
+    // Start offset of the contiguous per-column ColumnMetaPB region (absolute 
file offset).
+    optional uint64 col_meta_region_start = 11;
+    // Per-column external meta entries, in col_id order. Each entry contains 
the top-level
+    // unique id and the serialized length (in bytes) of its ColumnMetaPB in 
the external
+    // Column Meta Region.
+    repeated ColumnMetaEntryPB column_meta_entries = 12;
+    // Number of top-level columns in this segment for external meta 
addressing (col_id in [0, N)).
+    // Must equal column_meta_entries.size().
+    optional uint32 num_columns = 13;

Review Comment:
   看注释num columns 一定跟column_meta_entries.SIZE 相等,我们保存他的意义是什么?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to