yiguolei commented on code in PR #57702: URL: https://github.com/apache/doris/pull/57702#discussion_r2558449585
########## be/src/olap/rowset/segment_v2/external_col_meta_util.cpp: ########## @@ -0,0 +1,204 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "olap/rowset/segment_v2/external_col_meta_util.h" + +#include <limits> +#include <memory> +#include <utility> +#include <vector> + +#include "io/io_common.h" +#include "olap/rowset/segment_v2/variant/variant_ext_meta_writer.h" +#include "util/coding.h" +#include "util/faststring.h" + +namespace doris::segment_v2 { + +bool ExternalColMetaUtil::parse_external_meta_pointers( + const SegmentFooterPB& footer, ExternalColMetaUtil::ExternalMetaPointers* out) { + out->region_start = footer.col_meta_region_start(); + out->num_columns = footer.num_columns(); + // Validate pointers and basic consistency to ensure external meta is actually present. + if (out->region_start == 0) { + return false; Review Comment: 不要返回true or false，返回error status，因为error status 里我们可以详细记录错误原因。 返回true or false，这部分信息就丢了，我们如果真的有bug，定位起来就很难了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
