hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3450374941
##########
fe/fe-core/src/main/java/org/apache/doris/task/CreateReplicaTask.java:
##########
@@ -319,11 +320,14 @@ public TCreateTabletReq toThrift() {
tColumns = (List<TColumn>) tCols;
} else {
tColumns = new ArrayList<>();
+ Set<String> namedBfColumns =
Index.extractBloomFilterColumns(indexes);
Review Comment:
Reasonable. The real bug is in schema change shadow-tablet materialization
for non-base indexes.
Changed:
- Added Index.collectBloomFilterColumns(...) and
Index.filterBloomFilterColumnsBySchema(...)
- In SchemaChangeJobV2 and CloudSchemaChangeJobV2, materialize
per-shadow-schema shadowBfColumns and pass them down instead of relying on
tabletIndexes != null
- Added FE UTs for local/cloud schema change rollup shadow replicas and a
rollup regression case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
